This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
File dropdown on simulator #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeSlev
requested review from
abmahdy,
adclements,
markAtMicrosoft and
smmatte
as code owners
markAtMicrosoft
suggested changes
Aug 19, 2019
src/view/components/Dropdown.tsx
Outdated
| const parsedPath = parsePath(props.lastChosen); | ||
| const defaultText = | ||
| props.lastChosen !== "" | ||
| ? `Currently running: ${parsedPath[1]}` |
There was a problem hiding this comment.
Since this will be user facing, should we make it a constant and localize it?
src/view/components/Simulator.tsx
Outdated
| @@ -119,6 +142,16 @@ class Simulator extends React.Component<any, IState> { | |||
| const image = this.state.play_button ? StopLogo : PlayLogo; | |||
| return ( | |||
| <div className="simulator"> | |||
| <div className="file-selector"> | |||
| <Dropdown | |||
| label={"hi"} | |||
There was a problem hiding this comment.
Forgot to change the placeholder label? Same with styleLabel.
jonathanwangg
approved these changes
Aug 20, 2019
src/view/components/Simulator.tsx
Outdated
| @@ -174,6 +210,10 @@ class Simulator extends React.Component<any, IState> { | |||
| } | |||
| } | |||
|
|
|||
| protected onSelectBlur(event: React.FocusEvent<HTMLSelectElement>) { | |||
| console.log("BLURR", event.currentTarget.value); | |||
There was a problem hiding this comment.
Should probably be removed
Suggested change
| console.log("BLURR", event.currentTarget.value); |
| }); | ||
| break; | ||
| case "current-file": | ||
| console.log("Setting current file", message.state.running_file); |
There was a problem hiding this comment.
Could be removed?
Suggested change
| console.log("Setting current file", message.state.running_file); |
markAtMicrosoft
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a file dropdown on the simulator so users can choose a visible file to run
Type of change
Please delete options that are not relevant.
Testing:
Checklist: