Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Add telemetry to serial monitor commands #137

Merged
merged 3 commits into from
Aug 22, 2019

Conversation

LukeSlev
Copy link
Member

Description:

This PR adds telemetry events to the serial monitor commands

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing:

  • make sure telemetry events are fired for serial monitor events

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of an anonymous function to keep the arguments passed in the function for telemetry tracking. Just a small suggestion to remove a comment!

src/extension.ts Outdated
@@ -601,28 +601,40 @@ export async function activate(context: vscode.ExtensionContext) {
"pacifica.selectSerialPort",
() => {
// todo add telemetry after
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to remove this if your PR is getting merged 😄

Suggested change
// todo add telemetry after

@jonathanwangg
Copy link
Contributor

Tried to use the serial monitor after pulling and compiling this code and there appears to be some problems with the initialization of the serial monitor. Also there are conflicts to be resolved.

@LukeSlev LukeSlev merged commit 0534322 into dev Aug 22, 2019
@jonathanwangg jonathanwangg deleted the users/t-luslev/add-telemetry-serial branch August 26, 2019 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants