Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Changing the name of the extension in the repository. #146

Merged
merged 7 commits into from
Aug 27, 2019

Conversation

FMounz
Copy link
Contributor

@FMounz FMounz commented Aug 23, 2019

Description:

In this Pr all occurences of Pacifa have been changed to Device Simulator Express.

To complete this PR once documentation is completed

  • Go to VS code or any other editor that offers filtered search and replace functionalities.
  • Search Pacifica only on *.md files and replace by Device Simulator Express

In case some code changes have been made:

  • Go to VS code or any other editor that offers filtered search and replace functionalities.
  • Search Pacifica in string litterals matching word and case, replace by Device Simulator Express
    -Search pacifica matching case but not word in case it a variable like .pacifica. or pacifica replace by deviceSimulatorExpress for *ts , *.tsx and *.json filse and device-simulator_express for *.py files

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

For the debugger name in extension host, make sure to regenerate launch.json to have latest name updates

  • Check that once instructions followed, no occurrence of Pacifica remains in the repo.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good but blocking for someone else to merge later

@markAtMicrosoft markAtMicrosoft merged commit f770030 into dev Aug 27, 2019
@markAtMicrosoft markAtMicrosoft deleted the users/t-famoun/change-pacifica branch August 28, 2019 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants