Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Fix extension event listener #17

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Fix extension event listener #17

merged 1 commit into from
Jun 19, 2019

Conversation

LukeSlev
Copy link
Member

@LukeSlev LukeSlev commented Jun 19, 2019 •
edited
Loading

Description:

  • This PR fixes a bug we noticed where many event listeners were getting made on the extension side of the app
  • this ensures that there is only one event listener active at a time

Testing:

  • run the code multiple times and press a button; ensure that only one event is sent at a time in the debug console

@LukeSlev LukeSlev requested a review from smmatte as a code owner June 19, 2019 01:15
jonathanwangg
jonathanwangg approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as described

Christellah
Christellah approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working =)

abmahdy
abmahdy approved these changes Jun 19, 2019
View reviewed changes
Copy link

@abmahdy abmahdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@LukeSlev LukeSlev merged commit 56c13e9 into dev Jun 19, 2019
@LukeSlev LukeSlev deleted the users/t-luslev/fix-event-listener branch June 27, 2019 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abmahdy abmahdy abmahdy approved these changes

@Christellah Christellah Christellah approved these changes

@jonathanwangg jonathanwangg jonathanwangg approved these changes

@markAtMicrosoft markAtMicrosoft Awaiting requested review from markAtMicrosoft

@adclements adclements Awaiting requested review from adclements adclements is a code owner

@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukeSlev @jonathanwangg @Christellah @abmahdy