This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
Button interaction #195
Merged
Button interaction #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/microsoft/vscode-python-devicesimulator into users/t-anmah/button-integration
…/microsoft/vscode-python-devicesimulator into users/t-anmah/button-integration
…/microsoft/vscode-python-devicesimulator into users/t-anmah/button-integration
xnkevinnguyen
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
nasadigital
reviewed
Feb 10, 2020
src/process_user_code.py
Outdated
| cpx._Express__state[event] = new_state.get(event, cpx._Express__state[event]) | ||
|
|
||
|
|
||
| def update_microbit(new_state): |
There was a problem hiding this comment.
I think it would make more sense to handle the state changing logic inside each component, instead of having all the different components update state in this method. What do you think?
There was a problem hiding this comment.
that's true... I'll try implementing that for the next commit!
isadorasophia
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Microbit button should be fully integrated with the python code.
Type of change