-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
src/view/styles/Microbit.css
Outdated
} | ||
.sim-board, | ||
.sim-display, | ||
sim-button { | ||
fill: #111; | ||
} | ||
.sim-button-outer:hover { | ||
stroke: grey; | ||
stroke-width: 3px; | ||
stroke: orange !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can avoid using !important
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Removing it. Shouldn't be used when not necessary. Good catch
@@ -14,16 +17,24 @@ svg.sim.grayscale { | |||
} | |||
.sim-button { | |||
pointer-events: none; | |||
fill: "rgb(17, 17, 17)"; | |||
} | |||
.sim-button:active { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to give the metal strips at the bottom the same treatment (or are they not meant to be interacted with in the same way)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metal strips currently don't have functionality. We would add the same treatment if we implement functionality on those in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
Modify microbit svg to make it easier for the user to interact with buttons.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run format
and passes the checks innpm run check