Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Output dependency installation failures to an output channel #210

Merged
merged 4 commits into from
Feb 21, 2020
Merged

Output dependency installation failures to an output channel #210

merged 4 commits into from
Feb 21, 2020

Conversation

eishan05
Copy link
Contributor

@eishan05 eishan05 commented Feb 19, 2020 •
edited
Loading

Description:

This is a fix for issue #157 . When dependency installation from the first-run prompt popup fails, the error log is not shown to the user. With this change, the error log is output to the "Installation Error" output channel in the VS code window, so the user can debug installation issues and get started with the extension quicker.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing:

  • Deliberately run an incorrect command in the installPythonDependencies method to ensure that the failed command run is being logged to the output channel.

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@msftclas
Copy link

msftclas commented Feb 19, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

vandyliu
vandyliu approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👯‍♂

xnkevinnguyen
xnkevinnguyen approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nasadigital
nasadigital approved these changes Feb 20, 2020
View reviewed changes
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@vandyliu
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@vandyliu
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@vandyliu vandyliu merged commit 532d196 into microsoft:dev Feb 21, 2020
@vandyliu vandyliu mentioned this pull request Feb 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nasadigital nasadigital nasadigital approved these changes

@xnkevinnguyen xnkevinnguyen xnkevinnguyen approved these changes

@vandyliu vandyliu vandyliu approved these changes

@abmahdy abmahdy Awaiting requested review from abmahdy abmahdy is a code owner

@adclements adclements Awaiting requested review from adclements adclements is a code owner

@iennae iennae Awaiting requested review from iennae

@isadorasophia isadorasophia Awaiting requested review from isadorasophia

@markAtMicrosoft markAtMicrosoft Awaiting requested review from markAtMicrosoft

@sagarmanchanda sagarmanchanda Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner

@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eishan05 @msftclas @vandyliu @nasadigital @xnkevinnguyen