Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Add telemetry for python #213

Merged
merged 14 commits into from
Feb 22, 2020
Merged

Conversation

vandyliu
Copy link
Contributor

Description:

  • Add telemetry for microbit on python side so we know what type of code our users are writing
  • Also fixed bug that stopped telemetry from sending

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

src/common/telemetry.py Outdated Show resolved Hide resolved
xnkevinnguyen
xnkevinnguyen approved these changes Feb 21, 2020
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good :)

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job 👍

src/common/telemetry.py Outdated Show resolved Hide resolved
src/common/telemetry.py Show resolved Hide resolved
@vandyliu vandyliu merged commit 72b9f1e into dev Feb 22, 2020
@vandyliu vandyliu deleted the users/t-vali/add-telemetry-for-python branch February 22, 2020 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants