Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Separated telemetry metrics for debugger #214

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

vandyliu
Copy link
Contributor

Description:

  • Telemetry will record whether the user is debugging microbit or CPX

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandyliu vandyliu merged commit 97cb358 into dev Feb 21, 2020
@vandyliu vandyliu deleted the users/t-vali/discrete-debugger-telemetry branch February 21, 2020 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants