Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Debug Adapter Tracker Implementation #217

Merged
merged 16 commits into from
Feb 26, 2020
Merged

Debug Adapter Tracker Implementation #217

merged 16 commits into from
Feb 26, 2020

Conversation

xnkevinnguyen
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen commented Feb 21, 2020

Description:

Implement the debug adapter tracker to log the state of the debugger and capture the messages.

The UI will react to the messages emitted by debug adapter tracker

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really say much about the React bit, but LGTM 🍰

src/debugger/debugAdapter.ts Outdated Show resolved Hide resolved
src/view/App.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandyliu vandyliu merged commit 58e989e into dev Feb 26, 2020
@vandyliu vandyliu deleted the users/t-xunguy/dap branch February 26, 2020 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants