-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
.showInformationMessage( | ||
CONSTANTS.INFO.ARE_YOU_SURE, | ||
DialogResponses.INSTALL_NOW, | ||
DialogResponses.DONT_INSTALL | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be ok to remove this prompt, as it is the third prompt in a row asking about installing dependencies. Up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we should leave it in for now, since people who just close popups on instinct should be advised that the extension won't work without installing dependencies! Maybe we can incorporate this info into an earlier popup later on :0
await installDependenciesWrapper( | ||
context, | ||
pythonExecutableName | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't install the dependencies (perhaps you miss the prompts) and try running some micro:bit code, VS Code only shows a generic error:
[ERROR] Traceback (most recent call last):
File "c:\Users\user\.vscode\extensions\vscode-python-devicesimulator\out\process_user_code.py", line 26, in <module>
from common.telemetry import telemetry_py
File "c:\Users\user\.vscode\extensions\vscode-python-devicesimulator\out\common\telemetry.py", line 1, in <module>
from applicationinsights import TelemetryClient
ModuleNotFoundError: No module named 'applicationinsights'
It would be much more helpful if we could show the user a more helpful message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! Perhaps that'd be good for another release, since we're rushing for the release in an hour :'''(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix 🛫 🌕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be very useful to add some telemetry to the prompts and see where users end up installing the dependencies to make data driven decisions in the future.
Description:
User flow fixes, organization, and asks users if they want install globally if they refuse to do it in a venv
Type of change
Limitations:
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run format
and passes the checks innpm run check