Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Venv Telemetry and Structure Refactoring #240

Merged
merged 5 commits into from
Mar 5, 2020

Conversation

andreamah
Copy link
Contributor

@andreamah andreamah commented Mar 4, 2020

Description:

Adding telemetry to the new venv setup process merged in #218 .

EDIT: also re-structured setup code. Now, the code for setup is abstracted into a SetupService object. The telemetryAI object is now passed in within the SetupService constructor and setupEnv is called whenever the setup process needs to be triggered.

Type of change

  • New feature (non-breaking change which adds functionality)

Testing:

Tested setup process (common flows)

  • installing virtual environment in extension
  • installing with personal virtual environment

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

src/constants.ts Outdated Show resolved Hide resolved
@xnkevinnguyen
Copy link
Contributor

Would be nice to have venv as a service where you would only set telemetry ai once as an attribute

@andreamah andreamah changed the title venv telemetry Venv Telemetry and Structure Refactoring Mar 5, 2020
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Will be nice to have telemetry

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏖🏖🏖

@andreamah andreamah merged commit 33828ab into dev Mar 5, 2020
@andreamah andreamah deleted the users/t-anmah/venv-telemetry branch March 5, 2020 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants