Autosave file when deploying #259

vandyliu · 2020-03-13T22:59:49Z

Description:

Auto saves the file when deploying to device

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Manual testing
Test A
Test B

Checklist:

My code follows the style guidelines of this project
My code has been formatted with npm run format and passes the checks in npm run check
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

xnkevinnguyen · 2020-03-13T23:26:42Z

src/extension.ts

@@ -682,6 +682,8 @@ export async function activate(context: vscode.ExtensionContext) {
                DialogResponses.MESSAGE_UNDERSTOOD
            );
        } else {
+            await fileSelectionService.getCurrentTextDocument().save();


such a great service to use :D

nasadigital

LGTM

vandyliu added 2 commits March 13, 2020 15:48

first commit

cc1bb10

formatted

88ba12c

vandyliu requested review from xnkevinnguyen and andreamah March 13, 2020 22:59

vandyliu requested review from abmahdy, adclements, iennae, isadorasophia, markAtMicrosoft, nasadigital, sagarmanchanda and smmatte as code owners March 13, 2020 22:59

xnkevinnguyen approved these changes Mar 13, 2020

View reviewed changes

nasadigital approved these changes Mar 16, 2020

View reviewed changes

vandyliu merged commit 1a37f18 into dev Mar 16, 2020

vandyliu deleted the users/t-vali/autosave-when-deploying branch March 16, 2020 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autosave file when deploying #259

Autosave file when deploying #259

vandyliu commented Mar 13, 2020

xnkevinnguyen Mar 13, 2020

vandyliu Mar 14, 2020

nasadigital left a comment

Autosave file when deploying #259

Autosave file when deploying #259

Conversation

vandyliu commented Mar 13, 2020

Description:

Type of change

Limitations:

Testing:

Checklist:

xnkevinnguyen Mar 13, 2020

Choose a reason for hiding this comment

vandyliu Mar 14, 2020

Choose a reason for hiding this comment

nasadigital left a comment

Choose a reason for hiding this comment