Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Description UI change to Callout #261

Merged
merged 17 commits into from
Mar 18, 2020
Merged

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 16, 2020

AB#34026

Description:

  • Note: my vscode color settings are a little messed up on my computer so the GIF colors may look off so take a look for yourselves
  • Changed description to a callout
  • Removed scroll from sensor modal (so that there is only one scroll bar: the main one)
    Light Mode Change
    High Contrast Mode Change
    Dark  Mode Change

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xnkevinnguyen
Copy link
Contributor

Awesome work Vandy! Good work on the frontend side :)

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thanks for all of your hard work 😊

@nasadigital
Copy link

This is how it looks for me:
i_before
After hovering:
2020-03-18
Any idea why this is happening?

@vandyliu
Copy link
Contributor Author

vandyliu commented Mar 18, 2020

This is how it looks for me:
i_before
After hovering:
2020-03-18
Any idea why this is happening?

@nasadigital
Did you run npm i before compiling? That's the only thing I can think of right now.

@nasadigital
Copy link

nasadigital commented Mar 18, 2020

@vandyliu Yup, tried it again but it looks the same.
I ran:

$ npm install
$ npm run compile

followed by "Run Extension" in VS Code.
Do you know if this issue is likely because of my setup or if it will be something more widespread?
By the way, the tooltip shows the description properly it's only the icon that is not showing.

@xnkevinnguyen
Copy link
Contributor

@vandyliu Yup, tried it again but it looks the same.
I ran:

$ npm install
$ npm run compile

followed by "Run Extension" in VS Code.
Do you know if this issue is likely because of my setup or if it will be something more widespread?
By the way, the tooltip shows the description properly it's only the icon that is not showing.

Sometimes Vscode seems to not load some elements on the webview correctly. Try closing vscode and reopening it if that's not already done.

@nasadigital
Copy link

Sometimes Vscode seems to not load some elements on the webview correctly. Try closing vscode and reopening it if that's not already done.

@xnkevinnguyen That's interesting. I reopened VS Code multiple times, but should I try uninstall -> install?

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great job!

@vandyliu vandyliu merged commit 75b7040 into dev Mar 18, 2020
@vandyliu vandyliu deleted the users/t-vali/description-ui-change branch March 18, 2020 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants