Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Changed "Try it Description" by removing "we are currently working on...", adding "+1 on github for feature implementation" and other CSS changes #269

Merged
merged 4 commits into from
Mar 19, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 19, 2020

AB#34108 AB#34110

Description:

New versions:
new changes
new changes

Old versions (Notice blue arrow SVG and words flowing too far to the right):
Old versions
Old versions

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested on micro:bit and CPX simulator
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for also sharing screenshots of the associated changes in the PRs 😄

src/view/styles/ToolBar.css Show resolved Hide resolved
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@vandyliu vandyliu merged commit de76a32 into dev Mar 19, 2020
@vandyliu vandyliu deleted the users/t-vali/try-it-description-change branch March 19, 2020 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants