Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Buttons Integration for clue #286

Merged
merged 16 commits into from
Apr 1, 2020
Merged

Buttons Integration for clue #286

merged 16 commits into from
Apr 1, 2020

Conversation

xnkevinnguyen
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen commented Mar 31, 2020

Description:

Both the backend and front end for buttons on clue AB#34363

cluebuttons

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xnkevinnguyen xnkevinnguyen changed the title WIP: buttons for clue Buttons Integration for clue Mar 31, 2020
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! That was so fast and well done!! 🐰

src/clue/adafruit_clue.py Show resolved Hide resolved
src/clue/adafruit_clue.py Show resolved Hide resolved
src/view/components/microbit/Microbit_svg.tsx Show resolved Hide resolved
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, LGTM! 💯

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Merge it! 🙂

@vandyliu vandyliu merged commit 66f72f3 into dev Apr 1, 2020
@vandyliu vandyliu deleted the users/t-xunguy/buttons branch April 1, 2020 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants