This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnkevinnguyen
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
April 1, 2020 18:45
…osoft/vscode-python-devicesimulator into users/t-xunguy/clue-sensors
…osoft/vscode-python-devicesimulator into users/t-xunguy/clue-sensors
nasadigital
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for addressing the comments!
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
reviewed
Apr 6, 2020
vandyliu
suggested changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some suggestions for the descriptions but other than that it LGTM!
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-Authored-By: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
@vandyliu Thanks for your text suggestions. They were all applied!!! :) |
vandyliu
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP ITTTTT
andreamah
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on all ends!!! 🤩
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make all the sensors for clue.
AB#34292
AB#34296
AB#34297
List of sensors: Temperature, Light accelerometer, Leds, push_button, gpio, speaker, sound , pressure, humidity, gesture, proximity
Type of change
Testing Steps