Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Getting Started Update for CLUE! #295

Merged
merged 14 commits into from
Apr 6, 2020
Merged

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Apr 2, 2020

AB#34303

Description:

  • Changed name of CPX from "CPX" to "Circuit Playground Express" to be consistent with command pallet
  • Updated indentation of code blocks to 4 spaces instead of 2 spaces
  • Added step 5 for micro:bit
  • Added entire section for CLUE
    CLUE Getting Started
  • Any and all opinions welcomed!

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for helping me with this

src/view/pages/gettingStarted.tsx Outdated Show resolved Hide resolved
src/view/pages/gettingStarted.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page looks great! (●'◡'●)

src/view/pages/__snapshots__/gettingStarted.spec.tsx.snap Outdated Show resolved Hide resolved
src/view/pages/__snapshots__/gettingStarted.spec.tsx.snap Outdated Show resolved Hide resolved
Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 😁

src/view/pages/gettingStarted.tsx Show resolved Hide resolved
src/view/pages/gettingStarted.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandyliu vandyliu merged commit 52e4e67 into dev Apr 6, 2020
@vandyliu vandyliu deleted the users/t-vali/getting-started-clue branch April 6, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants