Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Creating Preview Mode For CLUE #303

Merged
merged 24 commits into from
Apr 9, 2020
Merged

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Apr 8, 2020

Description:

  • Preview Mode is added to CLUE
  • To enable preview mode, go to settings and enable Device Simulator Express: Enable Preview Mode
  • Afterwards, CLUE will be available in the selection when you open the commands: New File, Open Simulator and Deploy To Device
  • I retrieve the isPreviewMode boolean every time we call the command in case the user has changed it since a previous time
  • Added section to CLUE getting started about how to enable preview mode

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/extension.ts Show resolved Hide resolved
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks 😻

src/view/pages/gettingStarted.tsx Show resolved Hide resolved
@vandyliu vandyliu merged commit 25b22c4 into dev Apr 9, 2020
@vandyliu vandyliu deleted the users/t-vali/clue-preview-mode branch April 9, 2020 05:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants