This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamah
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
April 8, 2020 17:28
Confirmed tested on MAC |
vandyliu
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xnkevinnguyen
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Awesome fix, as always. Is it possible to add a comment where we say that this part is necessary for unix systems? Someone in the future might code in windows and remove it not knowing it's necessary
…m/microsoft/vscode-python-devicesimulator into users/t-anmah/clue-unix-fix
nasadigital
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch (again)!
LGTM
…osoft/vscode-python-devicesimulator into users/t-anmah/clue-unix-fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Clue simulator should work on Ubuntu with these changes 🛫🚀
Issue:
On UNIX systems, the large base64 image string would be split up when being sent to the front-end. To fix this, the front-end will collect incomplete messages and add them to the beginning of incoming new messages to see if they work there.
For this to work, it relies on the fact that the child process triggered by
process_user_code.py
only sends JSON-formatted strings to stdout. Fortunately,process_user_code.py
already re-formats print strings in JSON before sending them to the frontend.Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Used mega-test from #290 , but I ran on Ubuntu.
NOTE: this test needs some slideshow bmp photos in the current working directory!
Checklist:
npm run format
and passes the checks innpm run check