-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
Think you forgot about the killing of the process on webview close 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why do we have a single PR to do so many things? We need to limit PRs to doing one thing, then move on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Nice changes that'll be helpful for the user. Only suggestion would be to either move the runSimulator()
or break it down into smaller methods since it's getting quite long with nested if
and switch
statements.
To avoid adding more things in that PR I think we should have a separate PR for refactoring the |
Description:
In this PR, we have the following improvements :
process_user_code.py
anddevice.py
to run if no file has been selected beforeType of change
Please delete options that are not relevant.
Limitations:
The file name checking is not part of this PR, we still allow all names on simulator and device
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: