-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
…temperaturSensorLogic
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Little review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FMounz Some comments, something funky is goin on
Michelle insisted on having this one maybe talk to her |
Also cause this is a new feature and we have tests on the python side already would you be cool to add tests for this? |
Blocked until we get @MichelleYAOOO gives feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending some changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description:
This PR adds the support for the shake sensor. The user can now call the function cpx.shake() and see the effects,
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
cpx.shake()
. The Simulator should be updated accordingly. Example:Checklist: