Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Adding mock calls for missing API functionalities. #95

Merged
merged 14 commits into from
Aug 8, 2019

Conversation

FMounz
Copy link
Contributor

@FMounz FMounz commented Aug 4, 2019

Description:

This PR adds mock call for the functionalities that are not implemented by our extension.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

The logic for those functionalities are not implemented it only allows use to have auto completion for those.
No real test are available for this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Go to the API repo and make sure all unimplemented functionalities are available (properties and functions)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/adafruit_circuitplayground/express.py Show resolved Hide resolved
src/adafruit_circuitplayground/express.py Outdated Show resolved Hide resolved
Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception works like a charm, just some changes needed on the docstrings themselves. For the actual descriptions you could probably just grab those from the adafruit library itself for consistency! - https://circuitpython.readthedocs.io/projects/circuitplayground/en/latest/_modules/adafruit_circuitplayground/express.html#Express

src/adafruit_circuitplayground/express.py Outdated Show resolved Hide resolved
src/adafruit_circuitplayground/express.py Outdated Show resolved Hide resolved
src/adafruit_circuitplayground/express.py Outdated Show resolved Hide resolved
src/adafruit_circuitplayground/express.py Outdated Show resolved Hide resolved
src/adafruit_circuitplayground/express.py Outdated Show resolved Hide resolved
FMounz and others added 3 commits August 7, 2019 23:42
Co-Authored-By: Luke Slevinsky <lslevins@ualberta.ca>
Co-Authored-By: Luke Slevinsky <lslevins@ualberta.ca>
@FMounz
Copy link
Contributor Author

FMounz commented Aug 8, 2019

@LukeSlev made here some changes i think are useful. to avoid misunderstandings, I will keep docstring short with no description and I really think it is more suitable.

FMounz and others added 2 commits August 8, 2019 09:23
Co-Authored-By: Luke Slevinsky <lslevins@ualberta.ca>
@FMounz FMounz merged commit 5faf64b into dev Aug 8, 2019
@FMounz FMounz deleted the user/t-famoun/complete_api_calls branch August 10, 2019 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants