-
Notifications
You must be signed in to change notification settings - Fork 47
Adding mock calls for missing API functionalities. #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exception works like a charm, just some changes needed on the docstrings themselves. For the actual descriptions you could probably just grab those from the adafruit library itself for consistency! - https://circuitpython.readthedocs.io/projects/circuitplayground/en/latest/_modules/adafruit_circuitplayground/express.html#Express
Co-Authored-By: Luke Slevinsky <lslevins@ualberta.ca>
Co-Authored-By: Luke Slevinsky <lslevins@ualberta.ca>
@LukeSlev made here some changes i think are useful. to avoid misunderstandings, I will keep docstring short with no description and I really think it is more suitable. |
Co-Authored-By: Luke Slevinsky <lslevins@ualberta.ca>
Description:
This PR adds mock call for the functionalities that are not implemented by our extension.
Type of change
Please delete options that are not relevant.
Limitations:
The logic for those functionalities are not implemented it only allows use to have auto completion for those.
No real test are available for this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: