Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird mix of quick pick and progress notification #19890

Closed
jrieken opened this issue Sep 27, 2022 · 2 comments · Fixed by #19925
Closed

Weird mix of quick pick and progress notification #19890

jrieken opened this issue Sep 27, 2022 · 2 comments · Fixed by #19925
Assignees
@karthiknadig
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on verified Verification succeeded
Milestone
September 2022

Comments

@jrieken
Copy link
Member

jrieken commented Sep 27, 2022

Testing #19883

  • run "Create Env > venv"
  • while quick pick shows a progress notification appears telling me that quick pick is open.
  • that's very confusing UI, progress should only show after all input is gathered
Screen.Recording.2022-09-27.at.16.46.25.mov
@jrieken
Copy link
Member Author

jrieken commented Sep 27, 2022

fyi @daviddossett for quick quick UX guidelines

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 27, 2022
@daviddossett
Copy link

Agreed that we should avoid using progress notifications as a sort of await metaphor. Was this solving some sort of known issue e.g. users didn't know to make a selection?

@karrtikr karrtikr mentioned this issue Sep 27, 2022
Closed
@karthiknadig karthiknadig added this to the September 2022 milestone Sep 28, 2022
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug area-environments Features relating to handling interpreter environments needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Sep 28, 2022
@karthiknadig karthiknadig mentioned this issue Sep 30, 2022
Merged
karthiknadig added a commit that referenced this issue Oct 3, 2022
@karthiknadig
Fix bugs found during TPI (#19925)
ae63943 
Closes #19889
Closes #19890
Closes #19891
Closes #19894
Closes #19897
Closes #19852
Closes #19851
Closes #19838
Closes #19916
Closes #19917
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this issue Oct 4, 2022
@karthiknadig @eleanorjboyd
Fix bugs found during TPI (microsoft#19925)
51d80fe 
Closes microsoft#19889
Closes microsoft#19890
Closes microsoft#19891
Closes microsoft#19894
Closes microsoft#19897
Closes microsoft#19852
Closes microsoft#19851
Closes microsoft#19838
Closes microsoft#19916
Closes microsoft#19917
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Oct 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
@karthiknadig @wesm
Fix bugs found during TPI (microsoft/vscode-python#19925)
56496ab 
Closes microsoft/vscode-python#19889
Closes microsoft/vscode-python#19890
Closes microsoft/vscode-python#19891
Closes microsoft/vscode-python#19894
Closes microsoft/vscode-python#19897
Closes microsoft/vscode-python#19852
Closes microsoft/vscode-python#19851
Closes microsoft/vscode-python#19838
Closes microsoft/vscode-python#19916
Closes microsoft/vscode-python#19917
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

Fix bugs found during TPI karthiknadig/vscode-python
4 participants
@jrieken @TylerLeonhardt @karthiknadig @daviddossett