Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect ActiveState Python Runtimes #20532

Closed
mitchell-as opened this issue Jan 19, 2023 · 4 comments · Fixed by #20534
Closed

Detect ActiveState Python Runtimes #20532

mitchell-as opened this issue Jan 19, 2023 · 4 comments · Fixed by #20534
Assignees
@karrtikr
Labels
area-environments Features relating to handling interpreter environments author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2023

Comments

@mitchell-as
Copy link

The ActiveState Platform provides downloadable Python runtimes that can be installed on end-user machines with the help of a command line tool. VSCode can leverage this command line tool to find these Python runtimes and allow the user to set them as the default Python interpreter and/or switch between them using either the "Python: Select Interpreter" command, or the statusbar button.

ActiveState will supply the PR for this feature.
@mitchell-as mitchell-as added the feature-request Request for new features or functionality label Jan 19, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 19, 2023
mitchell-as added a commit to mitchell-as/vscode-python that referenced this issue Jan 19, 2023
@mitchell-as
Detect ActiveState Python runtimes (microsoft#20532)
a97d56e
mitchell-as added a commit to mitchell-as/vscode-python that referenced this issue Jan 19, 2023
@mitchell-as
Detect ActiveState Python runtimes (microsoft#20532)
2d959cb
mitchell-as added a commit to mitchell-as/vscode-python that referenced this issue Jan 19, 2023
@mitchell-as
Detect ActiveState Python runtimes (microsoft#20532)
a39ba90
mitchell-as added a commit to mitchell-as/vscode-python that referenced this issue Jan 19, 2023
@mitchell-as
Detect ActiveState Python runtimes (microsoft#20532)
573c13f
@mitchell-as mitchell-as mentioned this issue Jan 19, 2023
Merged
mitchell-as added a commit to mitchell-as/vscode-python that referenced this issue Jan 19, 2023
@mitchell-as
Detect ActiveState Python runtimes (microsoft#20532)
185ed5c
mitchell-as added a commit to mitchell-as/vscode-python that referenced this issue Jan 23, 2023
@mitchell-as
Detect ActiveState Python runtimes (microsoft#20532)
fe3e69d
mitchell-as added a commit to mitchell-as/vscode-python that referenced this issue Jan 23, 2023
@mitchell-as
Detect ActiveState Python runtimes (microsoft#20532)
d6ba0a7
@karrtikr
Copy link

Thanks for the PR, we'll have a look and decide accordingly.

@karrtikr karrtikr added area-environments Features relating to handling interpreter environments needs spike Label for issues that need investigation before they can be worked on. and removed triage-needed Needs assignment to the proper sub-team labels Jan 23, 2023
@karrtikr karrtikr added needs PR Ready to be worked on and removed needs spike Label for issues that need investigation before they can be worked on. labels Feb 2, 2023
@karrtikr karrtikr added this to the February 2023 milestone Feb 2, 2023
karthiknadig pushed a commit that referenced this issue Feb 22, 2023
@mitchell-as
Detect ActiveState Python runtimes (#20534)
c18e8c9 
Closes #20532
@karrtikr
Copy link

@mitchell-as Feature should be out in the pre-release version of the extension, use the following to verify it works:

image

@karrtikr karrtikr added verification-needed Verification of issue is requested author-verification-requested Issues potentially verifiable by issue author labels Feb 22, 2023
@karrtikr
Copy link

@mitchell-as @Naatan Can you make sure it works in pre-release?

@mitchell-as
Copy link
Author

@karrtikr Yes, it works in the Pre-Release version. Thank you!

@karrtikr karrtikr added the verified Verification succeeded label Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
@debonte @karthiknadig
@mitchell-as @petetronic @eleanorjboyd
Merge latest upstream python extension
34c70bb 
--------------------
Commit message for microsoft/vscode-python@fc72be9:

Show `Python: Report issue` command in palette regardless of whether a Python file is opened (microsoft/vscode-python#20726)

Closes microsoft/vscode-python#20723
--------------------
Commit message for microsoft/vscode-python@c18e8c9:

Detect ActiveState Python runtimes (microsoft/vscode-python#20534)

Closes microsoft/vscode-python#20532
--------------------
Commit message for microsoft/vscode-python@2152cd9:

Don't set `formatOnType` for auto-indent experiment if it's already set (microsoft/vscode-python#20710)


--------------------
Commit message for microsoft/vscode-python@995b0bc:

Add support for 'back' to all create env UI. (microsoft/vscode-python#20693)

Closes microsoft/vscode-python#20274


### Usage

This change allows callers of the Create Environment command to handle
`Back` and `Cancel`:
``` typescript
let result: CreateEnvironmentResult | undefined;
try {
    const result = await commands.executeCommand("python.createEnvironment", {showBackButton: true});
} catch(e) {
   // error while creating environment
}

if (result?.action === 'Back') {
    // user clicked Back
}

if (result?.action === 'Cancel') {
    // user pressed escape or Cancel
}
```
I decided to go with `result?.action` because we don't have a npm
package for python extension API so catching particular exception might
be error prone with `ex instanceof <error>`. We will provide a proper
interface via `api.environments` for create environment, and
contribution to create environment. Until that point this command will
provide the stop gap.

### Notes

1. I did not use the multi-step input that is used in the rest of the
extension because, the existing implementation does not have context.
Consider the following scenario: venv -> workspace select -> python
select -> packages. Assume that there is only one workspace, and we
don't show the workspace selection UI, that decision is done inside the
workspace step. So, if there is only 1 workspace it is a short circuit
to next step. User is on python selection and clicks `back`, workspace
selection short circuits to next step which is python selection. So,
from user perspective, back does not work. This can be fixed by sending
context that the reason control moved to previous step was because user
clicked on back.
2. This makes a change to old multi step API to rethrow the exception,
if user hits `back` and the current step has no steps to go back to.
--------------------
Commit message for microsoft/vscode-python@f3ecbf5:

Fix-conda-version-parsing (microsoft/vscode-python#20674)


--------------------
Commit message for microsoft/vscode-python@a6a6f50:

Inactive pytest run command (microsoft/vscode-python#20653)

Here the new flow is created but kept inactive for the pytest execution
--------------------
Commit message for microsoft/vscode-python@2202fbe:

Call the correct API to determine if a user is in treatment or control group (microsoft/vscode-python#20690)

Closes microsoft/vscode-python#20183
--------------------
Commit message for microsoft/vscode-python@b0ab10d:

Only use activated environment from terminal if VSCode was launched via CLI (microsoft/vscode-python#20667)

Closes microsoft/vscode-python#20644
--------------------
Commit message for microsoft/vscode-python@02a92fc:

Ensure interpreter path isn't truncated for workspace-relative paths when storing value (microsoft/vscode-python#20661)

For microsoft/vscode-python#20660

I'm not quite sure why this was done. It doesn't make sense to do this
only for display.
--------------------
Commit message for microsoft/vscode-python@377067f:

Use correct API to get interpreter path for language servers (microsoft/vscode-python#20656)

For microsoft/vscode-python#20644 closes
microsoft/vscode-python#20657
--------------------
Commit message for microsoft/vscode-python@cd6ca9d:

Remove `isort` extension dependency (microsoft/vscode-python#20577)

Closes microsoft/vscode-python#20586

Lead-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Erik De Bonte <erikd@microsoft.com>
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: mitchell <mitchellb@activestate.com>
Co-authored-by: Pete Farland <pete.farland@posit.co>
Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
@debonte @karthiknadig
@mitchell-as @petetronic @eleanorjboyd @wesm
Merge latest upstream python extension
8292d65 
--------------------
Commit message for microsoft/vscode-python@fc72be9:

Show `Python: Report issue` command in palette regardless of whether a Python file is opened (microsoft/vscode-python#20726)

Closes microsoft/vscode-python#20723
--------------------
Commit message for microsoft/vscode-python@c18e8c9:

Detect ActiveState Python runtimes (microsoft/vscode-python#20534)

Closes microsoft/vscode-python#20532
--------------------
Commit message for microsoft/vscode-python@2152cd9:

Don't set `formatOnType` for auto-indent experiment if it's already set (microsoft/vscode-python#20710)


--------------------
Commit message for microsoft/vscode-python@995b0bc:

Add support for 'back' to all create env UI. (microsoft/vscode-python#20693)

Closes microsoft/vscode-python#20274


### Usage

This change allows callers of the Create Environment command to handle
`Back` and `Cancel`:
``` typescript
let result: CreateEnvironmentResult | undefined;
try {
    const result = await commands.executeCommand("python.createEnvironment", {showBackButton: true});
} catch(e) {
   // error while creating environment
}

if (result?.action === 'Back') {
    // user clicked Back
}

if (result?.action === 'Cancel') {
    // user pressed escape or Cancel
}
```
I decided to go with `result?.action` because we don't have a npm
package for python extension API so catching particular exception might
be error prone with `ex instanceof <error>`. We will provide a proper
interface via `api.environments` for create environment, and
contribution to create environment. Until that point this command will
provide the stop gap.

### Notes

1. I did not use the multi-step input that is used in the rest of the
extension because, the existing implementation does not have context.
Consider the following scenario: venv -> workspace select -> python
select -> packages. Assume that there is only one workspace, and we
don't show the workspace selection UI, that decision is done inside the
workspace step. So, if there is only 1 workspace it is a short circuit
to next step. User is on python selection and clicks `back`, workspace
selection short circuits to next step which is python selection. So,
from user perspective, back does not work. This can be fixed by sending
context that the reason control moved to previous step was because user
clicked on back.
2. This makes a change to old multi step API to rethrow the exception,
if user hits `back` and the current step has no steps to go back to.
--------------------
Commit message for microsoft/vscode-python@f3ecbf5:

Fix-conda-version-parsing (microsoft/vscode-python#20674)


--------------------
Commit message for microsoft/vscode-python@a6a6f50:

Inactive pytest run command (microsoft/vscode-python#20653)

Here the new flow is created but kept inactive for the pytest execution
--------------------
Commit message for microsoft/vscode-python@2202fbe:

Call the correct API to determine if a user is in treatment or control group (microsoft/vscode-python#20690)

Closes microsoft/vscode-python#20183
--------------------
Commit message for microsoft/vscode-python@b0ab10d:

Only use activated environment from terminal if VSCode was launched via CLI (microsoft/vscode-python#20667)

Closes microsoft/vscode-python#20644
--------------------
Commit message for microsoft/vscode-python@02a92fc:

Ensure interpreter path isn't truncated for workspace-relative paths when storing value (microsoft/vscode-python#20661)

For microsoft/vscode-python#20660

I'm not quite sure why this was done. It doesn't make sense to do this
only for display.
--------------------
Commit message for microsoft/vscode-python@377067f:

Use correct API to get interpreter path for language servers (microsoft/vscode-python#20656)

For microsoft/vscode-python#20644 closes
microsoft/vscode-python#20657
--------------------
Commit message for microsoft/vscode-python@cd6ca9d:

Remove `isort` extension dependency (microsoft/vscode-python#20577)

Closes microsoft/vscode-python#20586

Lead-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Erik De Bonte <erikd@microsoft.com>
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: mitchell <mitchellb@activestate.com>
Co-authored-by: Pete Farland <pete.farland@posit.co>
Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-environments Features relating to handling interpreter environments author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

Detect ActiveState Python runtimes mitchell-as/vscode-python
3 participants
@karthiknadig @mitchell-as @karrtikr