Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect telemetry data for comparing environments detected by legacy and new python finder #23565

Closed
karthiknadig opened this issue Jun 6, 2024 · 2 comments · Fixed by #23646
Assignees
Labels
area-environments Features relating to handling interpreter environments area-native-locator Issues with Rust based python locator feature-request Request for new features or functionality needs PR Ready to be worked on verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jun 6, 2024
@karthiknadig karthiknadig added this to the June 2024 milestone Jun 6, 2024
@karthiknadig karthiknadig self-assigned this Jun 6, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 6, 2024
@karthiknadig karthiknadig added area-environments Features relating to handling interpreter environments needs PR Ready to be worked on area-native-locator Issues with Rust based python locator and removed triage-needed Needs assignment to the proper sub-team labels Jun 6, 2024
@DonJayamanne
Copy link

Problems

  • Counting envs by Kind in TS locator and comparing against Native locator will not work.
    E.g. /usr/bin/python could be treated as global by TS local and System by Native locator.
    This is a hypothetical example, the rules for global, unknown, system, etc are not easy and not easy to translate in new search algorithm.
  • Virtual envs from other worksapce folders can end up in cache thus end up being listed by other workspace folders.
    Native Locator will never find them.
    I.e. open folder A, and that has a venv named .venvA, now close and open folder B, the env .venvA still ends up in the list of envs and this will be reported as not found by Native locator.
    thats a false positive.
  • pyenv virtual envs are detected incorrectly.
    Python version is always incorrect even when clearing & reloading cachine #23661

Solutions

  • Check if all exes listed by TS locator are found in the list of exes returned by Native
  • Ignore pyenv virtual envs when comparing the counters

@karthiknadig /cc

DonJayamanne added a commit to DonJayamanne/pythonVSCode that referenced this issue Jun 24, 2024
Closes microsoft#23565

---------

Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
@Yoyokrazy Yoyokrazy added the verification-needed Verification of issue is requested label Jun 25, 2024
@amunger
Copy link

amunger commented Jun 25, 2024

I assume @karthiknadig or @DonJayamanne can just verify this since they will be the consumers of the telemetry

@amunger amunger added the author-verification-requested Issues potentially verifiable by issue author label Jun 25, 2024
@karthiknadig karthiknadig added verified Verification succeeded and removed verification-needed Verification of issue is requested author-verification-requested Issues potentially verifiable by issue author labels Jun 26, 2024
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this issue Jun 28, 2024
Closes microsoft#23565

---------

Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments area-native-locator Issues with Rust based python locator feature-request Request for new features or functionality needs PR Ready to be worked on verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants