Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly track Native REPL via watching onClosed event #23996

Closed
anthonykim1 opened this issue Aug 26, 2024 · 0 comments · Fixed by #23997
Closed

Correctly track Native REPL via watching onClosed event #23996

anthonykim1 opened this issue Aug 26, 2024 · 0 comments · Fixed by #23997
Assignees
@anthonykim1
Labels
area-repl bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team

Comments

@anthonykim1
Copy link

anthonykim1 commented Aug 26, 2024 •
edited
Loading

We did not have accurate state of whether native repl was closed or not, and also missed out on part of telemetry because every reopening did not count as a REPL instance.
@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug area-repl labels Aug 26, 2024
@anthonykim1 anthonykim1 self-assigned this Aug 26, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 26, 2024
@anthonykim1 anthonykim1 mentioned this issue Aug 26, 2024
Merged
@anthonykim1 anthonykim1 changed the title Dispose Native REPL after watching onClosed event Correctly track Native REPL via watching onClosed event Aug 26, 2024
@anthonykim1 anthonykim1 reopened this Aug 26, 2024
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this issue Sep 13, 2024
@anthonykim1
Correctly track native REPL state (microsoft#23997)
e2b2c21 
Resolves: microsoft#23996
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
area-repl bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly track native REPL state anthonykim1/vscode-python
1 participant
@anthonykim1