Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline parameter name hints in front of literal values #53

Closed
balta2ar opened this issue Nov 12, 2017 · 8 comments
Closed

Inline parameter name hints in front of literal values #53

balta2ar opened this issue Nov 12, 2017 · 8 comments
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@balta2ar
Copy link

I wonder whether it's possible to implement "parameter hints" as it's implemented in IntelliJ's IDEs.

screen-shot-2017-10-24-at-11 27 55

@brettcannon brettcannon added awaiting 1-decision area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality labels Nov 14, 2017
@brettcannon
Copy link
Member

Closing as a duplicate of #70

@balta2ar
Copy link
Author

@brettcannon This is not a duplicate. I believe this issue and #70 have different scopes. What I'm talking about is adding those small visual greyed out keywords (result, text, key, number). This request is not about displaying something in a tooltip.

@DonJayamanne DonJayamanne reopened this Nov 17, 2017
@balta2ar balta2ar changed the title Parameter name hints Inline parameter name hints in front of literal values Nov 17, 2017
@balta2ar
Copy link
Author

Hm, this may not be possible before microsoft/vscode#16221 is implemented.

@balta2ar
Copy link
Author

Hm, or maybe it is possible already: jacobdufault/cquery#85 (comment)

This can be done in vscode by using decorators (similar to how semantic highlighting works).

@balta2ar
Copy link
Author

balta2ar commented Feb 5, 2018

FTR: here is a relevant example that demonstrates how to use decorators: https://github.com/Microsoft/vscode-extension-samples/tree/master/decorator-sample

@brettcannon
Copy link
Member

Thanks for the suggestion, @balta2ar , but we think this takes the extension too far into IDE territory for us to implement.

@balta2ar
Copy link
Author

balta2ar commented Apr 6, 2018

Well, let me disagree. The whole idea of the python plugin (to my opinion) is to make Python developer's experience better. Otherwise we could've stayed with plain vim with no extensions.

And it IS one of those things that is helpful to users, that makes their experience better. Look at the issue in vscode: microsoft/vscode#16221, it's got so many upvotes, users want it. If this is too far into IDE, then how is this different from "Peek definition" feature? They both save time on jumping around, they provide context.

I understand the resources of the team are limited but at least keeping the issue open could make it more discoverable for potential contributors.

@brettcannon
Copy link
Member

We closed this specifically because we wouldn't accept a PR implementing this feature (otherwise it would have been left open and we would have added the 'help wanted' label). I realize you would like to see this and that some others might also find it useful, but we just don't think the cost of the feature and how it fits into the general design we are going for warrants the cost of implementing it. (Obviously people can free to implement this as a separate extension since there is nothing in our extension that would prevent it from working.)

As for the upvotes on the VS Code issue, there are 28, but that is actually rather small for the VS Code repo (e.g. it doesn't show up until page 6 when you sort by 👍 votes). And the fact this issue has been open for almost five months on our issue tracker and has not received any upvotes from another person means we are not seeing a high enough demand to reconsider our decision.

So I'm sorry but we won't be re-opening this.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants