Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node 12 #6621

Closed
janosh opened this issue Jul 17, 2019 · 3 comments
Closed

Upgrade to node 12 #6621

janosh opened this issue Jul 17, 2019 · 3 comments

Comments

@janosh
Copy link

janosh commented Jul 17, 2019

The contribution guide still lists node v10 as a prerequisite. v12 was released 3 months ago on April 23. Are there any plans to update?
@janosh janosh added the triage-needed Needs assignment to the proper sub-team label Jul 17, 2019
@DonJayamanne
Copy link

Closing this issue, as we're limited to the version of node that ships with VS Code.
Please check upstream on VS Code repo for progress on this (fyi you'll be interested in the upgrades to Electron in the VS Code repo)

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jul 17, 2019
@janosh
Copy link
Author

janosh commented Jul 17, 2019

Can't find an issue concerned with updating to Electron 5. Could that be tracked internally?

@janosh
Copy link
Author

janosh commented Jul 17, 2019

Never mind. They decided to skip Electron 5 and update straight to 6.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @janosh