Use pylance client if pylance client is available/enabled. #19912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heejaechang
added
skip package*.json
heejaechang
force-pushed
the
clientMove
branch
from
70b22c4
to
aba8cc7
Compare
heejaechang
force-pushed
the
clientMove
branch
from
d5a3610
to
1c3c449
Compare
|
Make sure to bump the engine version to latest on both the extensions. |
heejaechang
force-pushed
the
clientMove
branch
from
d2e4216
to
6dd7a53
Compare
heejaechang
changed the title
|
Closing this as blocked on #20002 . That is a meta issue tracking progress on the Jupyter <-> Python <-> (Pylance, Jedi, ...) communication. there might be changes to this design. so for now I am closing this. |
|
Ah okay, this is kind of the opposite of what we discussed today. Here Python is calling Pylance to start. |
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Pylance claims it supports client by itself, this change will let python core extension to let pylance to handle language client.