Respect VIRTUAL_ENV_PROMPT when calculating PS1
#23080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
added
bug
rzhao271
approved these changes
Mar 15, 2024
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 5, 2024
…ython#23080) Closes microsoft/vscode-python#22956 Because we calculate `PS1` ourselves due to a limitation: microsoft/vscode-python#22078, this environment variable may not end up being respected as do not use `PS1`. This PR fixes it.
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 8, 2024
…ython#23080) Closes microsoft/vscode-python#22956 Because we calculate `PS1` ourselves due to a limitation: microsoft/vscode-python#22078, this environment variable may not end up being respected as do not use `PS1`. This PR fixes it.
anthonykim1
added a commit
that referenced
this pull request
Apr 8, 2024
anthonykim1
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Apr 9, 2024
Resolves: microsoft#23193 microsoft#23184 Resolve duplicated (.venv) prompt for users terminal. Issue came from: microsoft#23080
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
May 10, 2024
Resolves: microsoft/vscode-python#23193 microsoft/vscode-python#23184 Resolve duplicated (.venv) prompt for users terminal. Issue came from: microsoft/vscode-python#23080
seeM
pushed a commit
to posit-dev/positron
that referenced
this pull request
May 12, 2024
Resolves: microsoft/vscode-python#23193 microsoft/vscode-python#23184 Resolve duplicated (.venv) prompt for users terminal. Issue came from: microsoft/vscode-python#23080
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
May 13, 2024
Resolves: microsoft/vscode-python#23193 microsoft/vscode-python#23184 Resolve duplicated (.venv) prompt for users terminal. Issue came from: microsoft/vscode-python#23080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22956
Because we calculate
PS1ourselves due to a limitation: #22078, this environment variable may not end up being respected as do not usePS1. This PR fixes it.