Fix incorrect runArguments assignment #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
- Coverage 14.32% 14.31% -0.02%
==========================================
Files 62 62
Lines 3273 3276 +3
Branches 427 427
==========================================
Hits 469 469
- Misses 2804 2807 +3
|
ruslan-bikkinin
changed the title
ruslan-bikkinin
added a commit
to ruslan-bikkinin/vscode-react-native
that referenced
this pull request
Aug 28, 2018
This reverts commit b9fbf69.
ruslan-bikkinin
added a commit
that referenced
this pull request
Aug 28, 2018
* Revert "FIx incorrect runArguments assignment (#779)" This reverts commit b9fbf69. * Revert "Update changelog (#775)" This reverts commit 5517641. * Revert "Remove code push images (#771)" This reverts commit b34bce9. * Revert "Added support for Build Multiple Versions of React Native app (#766)" This reverts commit 3e313f6. * Revert "Update debugging.md (#765)" This reverts commit fcfec28. * Revert "fix typo (#763)" This reverts commit 4dd439f. * merge * Revert "Use fork instead of spawn for AppWorker (#760)" This reverts commit 2df05fa. * Revert "Added some logging for debug (#759)" This reverts commit 46e2461. * Revert "[Android] Add reading SDK location from local.properties (#754)" This reverts commit 43e1a99. * Revert "Fixed error while stop expo packager (#753)" This reverts commit 77b86bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes critical issue with android debugging introduced in 0.6.14.
#777