Merge pull request #228 from microsoft/connor4312/2.3.4

v2.3.4

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+### 2.3.4 | 2022-07-31
+
+- Fix "insiders" string not matching correctly
+
 ### 2.3.3 | 2022-06-10
 
 - Disable GPU sandbox by default, fixing failures in some CI's.

lib/util.ts

@@ -28,8 +28,8 @@ switch (process.platform) {
 			process.arch === 'arm64'
 				? 'win32-arm64-archive'
 				: process.arch === 'ia32'
-					? 'win32-archive'
-					: 'win32-x64-archive';
+				? 'win32-archive'
+				: 'win32-x64-archive';
 		break;
 	default:
 		systemDefaultPlatform =
@@ -242,19 +242,16 @@ export function killTree(processId: number, force: boolean) {
 
 		// when killing a process in Windows its child processes are *not* killed but become root processes.
 		// Therefore we use TASKKILL.EXE
-		cp = spawn(path.join(windir, 'System32', 'taskkill.exe'), [
-			...force ? ['/F'] : [],
-			'/T',
-			'/PID',
-			processId.toString(),
-		], { stdio: 'inherit' });
+		cp = spawn(
+			path.join(windir, 'System32', 'taskkill.exe'),
+			[...(force ? ['/F'] : []), '/T', '/PID', processId.toString()],
+			{ stdio: 'inherit' }
+		);
 	} else {
 		// on linux and OS X we kill all direct and indirect child processes as well
-		cp = spawn('sh', [
-			path.resolve(__dirname, '../killTree.sh'),
-			processId.toString(),
-			force ? '9' : '15',
-		], { stdio: 'inherit' });
+		cp = spawn('sh', [path.resolve(__dirname, '../killTree.sh'), processId.toString(), force ? '9' : '15'], {
+			stdio: 'inherit',
+		});
 	}
 
 	return new Promise<void>((resolve, reject) => {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vscode/test-electron",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "scripts": {
     "compile": "tsc -p ./",
     "watch": "tsc -w -p ./",