-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should vsce deal with pre-release version identifiers? #148
Comments
This is by design today, we only allow numeric values and period in the version. I can add an item to the backlog to allow pre-release tags. |
This would be a good feature to have in Marketplace to publish pre-release versions of extensions. |
Note that the Marketplace seems to allow 4 digits (at least for other kind of extensions): X.Y.Z.build while vsce don't. |
was going through
incrementing the third digit ( |
I just ran into the same problem while trying to distribute an alpha version for testers. I'm not feeling comfortable distributing alpha extension packages which look like legit releases. |
The latest version (1.74.0) seems to support this. Strange - I didn't see anything having addressed this in the latest commits... |
While this is not implemented, should this be reflected here: https://code.visualstudio.com/api/references/extension-manifest#fields The docs for the I ran into this with |
+1 on this. The documentation specifically says:
But vsce does not support all SemVer compatible versions. Also, the marketplace is not SemVer compatible either. Taking |
Is this something that's still being considered? |
Just to pile on here -- I should have linked our issue when we hit this. In particular, in PowerShell/vscode-powershell#1880 (comment) we discuss the fact that |
Actually, I checked the spec and since the marketplace doesn't support an alphnumeric tag after a hyphen, it does not use Semantic Versioning v1, which specifies:
The marketplace seems to have its own versioning schema. |
It seems pretty obvious to me that everything living in the Node.js ecosystem should support SemVer 2.0. I hope this will be addressed and fixed soon. |
Merging into microsoft/vscode#15756 |
Not sure this is a bug. Perhaps its more of a request for clarification (depending whether the behavior is deliberate or accidental)
Semver version numbers can look like this (examples from here: http://semver.org/):
There can be a 'pre-release-tag' appended after the 3rd number, seperated by a '-'. This is also the convention of version for node packages as far as I know. It seems like vsce publish refuses such versions however.
First... I thought its a bug. But then I thought, maybe this could be deliberate? (E.g to prevent publishing of 'pre-release' versions on marketplace? But then its a bit odd it would accept a fourth number as the error suggests)
Please clarify what the rules are for publishing versions to marketplace (and consider fixing/changing it if this behavior isn't deliberate)
The text was updated successfully, but these errors were encountered: