Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate publisher on package #1011

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Validate publisher on package #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/package.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
validateVersion,
validateEngineCompatibility,
validateVSCodeTypesCompatibility,
validatePublisher,
} from './validation';
import { detectYarn, getDependencies } from './npm';
import * as GitHost from 'hosted-git-info';
Expand Down Expand Up @@ -1250,6 +1251,7 @@ export class ValidationProcessor extends BaseProcessor {

export function validateManifest(manifest: Manifest): Manifest {
validateExtensionName(manifest.name);
validatePublisher(manifest.publisher);

if (!manifest.version) {
throw new Error('Manifest missing field: version');
Expand Down
2 changes: 1 addition & 1 deletion src/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function validatePublisher(publisher: string): void {

if (!nameRegex.test(publisher)) {
throw new Error(
`Invalid publisher name '${publisher}'. Expected the identifier of a publisher, not its human-friendly name. Learn more: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions`
`Invalid publisher name '${publisher}'. Expected the identifier of a publisher, not its human-friendly name. Learn more: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions`
);
}
}
Expand Down