Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: probabilistic trigger v8 crash #1032

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: probabilistic trigger v8 crash #1032

merged 1 commit into from
Aug 12, 2024

Commits on Aug 12, 2024

  1. fix: probabilistic trigger v8 crash 

    There is a probability of triggering a v8 crash when running the `yarn list --prod --json` command. Related discussion: nodejs/node#51555

This issue does not always occur. When we build `vscode-reh-linux-arm64` in the Dockerfile, there is more than a 50% chance of failure.

If this PR is merged, the code related to DISABLE_V8_COMPILE_CACHE in vscode can also be removed (https://github.com/search?q=repo%3Amicrosoft%2Fvscode%20DISABLE_V8_COMPILE_CACHE&type=code).

Globally setting `DISABLE_V8_COMPILE_CACHE=1` will increase the entire build time by 3 to 5 minutes.

Signed-off-by: Kevin Cui <bh@bugs.cc>
    @BlackHole1
    BlackHole1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    af084f7 View commit details
    Browse the repository at this point in the history