-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for yarn workspaces #493
feat: Support for yarn workspaces #493
Conversation
…t-yarn-workspaces
@joaomoreno I resolved the merge conflicts with master. Any chance you can give this PR a review? |
Thanks for bring this up-to-date.
In #458 (comment). Is this still your opinion? Should #418 go in first? |
Only when you're actually considering it. If not, I can have another look at the .vscodeignore to see if I can fix it. I'm fine with both. |
@joaomoreno Ok, I checked and the Specifically for @phaumer use-case it would be a new feature request. The current functionality (in the main branch) does not allow you to include files that are "outside" of your package (+dependencies) scope. |
hello! any update on this? we're looking to move to yarn2 and this package is not yet compatible. There is a hacky workaround but would be nice to have this supported. |
are we there yet? already 2022. |
@joaomoreno Is there anything still missing on this PR that prevents it currently from getting merged? |
2023! |
@sebas2day Sorry for the delay here. I've brought the PR forward by merging |
Yes feel free to merge it 👍 |
Thank you for your patience! 🍻 |
wow, finally, thanks everyone for support! however I completely forgot why did I need this thing to be implemented. that was 4 projects ago, 2 companies ago... |
This reverts commit 3e8410b.
Fixes #300
This PR is inspired by #379.
I have included a small yarn workspaces fixture in order to test whether its collecting the files in the right way.