Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit file extensions to module imports #436

Merged
merged 7 commits into from
Dec 22, 2022

Conversation

hawkticehurst
Copy link
Member

Link to relevant issue

This pull request resolves #432
This pull request resolves #435

Description of changes

Fixes an ESM related bug caused by a lack of explicit file extensions (i.e. import file versus import file.js) in module imports.

@hawkticehurst
Copy link
Member Author

Note: I have temporarily removed the CI/CD pipelines related to building and deploying our Storybook docs as I've discovered the changes in this PR will break Storybook builds.

Our current Storybook configuration requires a CommonJS-based module system to run and this PR changes the toolkit to use an ESM-based system.

Removing CI/CD pipelines means the current version of the docs should remain for the time being and allow me to merge this PR before I head out for vacation next week.

cc @daviddossett @kkbrooks I think we should revisit how we think about docs in the new year because I've wanted to switch out Storybook for something else for a while and this might be the right time to do so.

@hawkticehurst hawkticehurst merged commit acadb09 into microsoft:main Dec 22, 2022
@hawkticehurst hawkticehurst deleted the esm-updates branch December 22, 2022 23:34
@kkbrooks
Copy link
Collaborator

kkbrooks commented Dec 27, 2022

@daviddossett @hawkticehurst I'll grab some time for us to chat about documentation in the New Year 😊

hawkticehurst added a commit that referenced this pull request Jan 13, 2023
Description of changes

Since the deploy docs CD pipeline was removed in #436 it broke the deploy docs readme badge, so removing it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module fails to import when running vitest Use file extensions explicitly
2 participants