Merge pull request #208486 from cpendery/fix/suggestion-sort

fix: terminal suggestions to sort by fuzzy score
microsoft · Mar 23, 2024 · 50b43a6 · 50b43a6
2 parents 711ca55 + 9203d2d
commit 50b43a6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/vs/workbench/services/suggest/browser/simpleCompletionItem.ts b/src/vs/workbench/services/suggest/browser/simpleCompletionItem.ts
@@ -27,7 +27,6 @@ export class SimpleCompletionItem {
 
 	// sorting, filtering
 	score: FuzzyScore = FuzzyScore.Default;
-	distance: number = 0;
 	idx?: number;
 	word?: string;
 

diff --git a/src/vs/workbench/services/suggest/browser/simpleCompletionModel.ts b/src/vs/workbench/services/suggest/browser/simpleCompletionModel.ts
@@ -40,7 +40,7 @@ export class SimpleCompletionModel {
 		private readonly _items: SimpleCompletionItem[],
 		private _lineContext: LineContext,
 		readonly replacementIndex: number,
-		readonly replacementLength: number
+		readonly replacementLength: number,
 	) {
 	}
 
@@ -174,15 +174,13 @@ export class SimpleCompletionModel {
 			}
 
 			item.idx = i;
-			// TODO: Word distance
-			item.distance = 1;//this._wordDistance.distance(item.position, item.completion);
 			target.push(item);
 
 			// update stats
 			labelLengths.push(item.completion.label.length);
 		}
 
-		this._filteredItems = target; // target.sort(this._snippetCompareFn);
+		this._filteredItems = target.sort((a, b) => b.score[0] - a.score[0]);
 		this._refilterKind = Refilter.Nothing;
 
 		this._stats = {