Skip to content

Commit

Permalink
Fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
Tyriar committed May 3, 2024
1 parent 881b796 commit 5a68b64
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
this._xtermReadyPromise.then(xterm => {
contribution.xtermReady?.(xterm);
});
this.onDisposed(() => {
this._register(this.onDisposed(() => {
contribution.dispose();
this._contributions.delete(desc.id);
// Just in case to prevent potential future memory leaks due to cyclic dependency.
Expand All @@ -592,7 +592,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
if ('_instance' in contribution) {
delete contribution._instance;
}
});
}));
}
}

Expand Down

0 comments on commit 5a68b64

Please sign in to comment.