Clean up file picker folder updating

microsoft · Jul 11, 2019 · 691914e · 691914e
1 parent b1621c1
commit 691914e
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/vs/workbench/services/dialogs/browser/remoteFileDialog.ts b/src/vs/workbench/services/dialogs/browser/remoteFileDialog.ts
@@ -65,7 +65,7 @@ export class RemoteFileDialog {
 	private remoteAgentEnvironment: IRemoteAgentEnvironment | null;
 	private separator: string;
 	private onBusyChangeEmitter = new Emitter<boolean>();
-	private updatingPromise: CancelablePromise<void>[] = [];
+	private updatingPromise: CancelablePromise<void> | undefined;
 
 	protected disposables: IDisposable[] = [
 		this.onBusyChangeEmitter
@@ -735,17 +735,16 @@ export class RemoteFileDialog {
 					this.filePickBox.valueSelection = [this.filePickBox.value.length, this.filePickBox.value.length];
 				}
 				this.busy = false;
-				this.updatingPromise.shift();
+				this.updatingPromise = undefined;
 			});
 		});
 
-		this.updatingPromise.push(updatingPromise);
-		// Always keep one update around so that we can get into the most recent folder.
-		if (this.updatingPromise.length > 1) {
-			this.updatingPromise.shift()!.cancel();
+		if (this.updatingPromise !== undefined) {
+			this.updatingPromise.cancel();
 		}
-		return updatingPromise;
+		this.updatingPromise = updatingPromise;
 
+		return updatingPromise;
 	}
 
 	private pathFromUri(uri: URI, endWithSeparator: boolean = false): string {