Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden editors cause issues with keybinding contexts #10358

Closed
bpasero opened this issue Aug 9, 2016 · 1 comment
Closed

Hidden editors cause issues with keybinding contexts #10358

bpasero opened this issue Aug 9, 2016 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority
Milestone
August 2016

Comments

@bpasero
Copy link
Member

bpasero commented Aug 9, 2016

Causing #9705 and #10122

Current thinking is to dispose editors once they become hidden.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Aug 9, 2016
@bpasero bpasero added this to the August 2016 milestone Aug 9, 2016
@bpasero bpasero self-assigned this Aug 9, 2016
This was referenced Aug 9, 2016
Closed
Closed
This was referenced Aug 15, 2016
Closed
Closed
@bpasero
Copy link
Member Author

bpasero commented Aug 22, 2016

Closing since #10075 landed

@bpasero bpasero closed this as completed Aug 22, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 22, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
1 participant
@bpasero