CMD+D in new unsaved file

[normalser]

• VSCode Version: 1.4.0-insiders
• OS Version: OSX

Steps to Reproduce:

1. Have 1 existing file open in VSCode
2. Click File/New (CMD+N) to create new unsaved file
3. Paste

abc def
abc def
abc def

1. Put cursor inside abc
2. Hit CMD+D multiple times
3. Problem: Nothing gets selected

[alexdima]

@wallverb I cannot reproduce:

[normalser]

Ok, so here are the steps that I can always reproduce on OSX (not sure if it's also problem on WIN)

1. Have one (and only one file fully open that is from project)
2. Press CMD+N to open new file/tab (don't double click tab bar because this way everything works ok for some reason)
3. Type text, try to select first word with CMD+D - nothing happens

Here is the gif:

[alexdima]

Thank you, I can reproduce with these steps! Root cause is the editorFocus context key, which gets set to true from a second CodeEditorWidget instance and then gets reset to false from the original CodeEditorWidget instance. Root cause is #10358.

@bpasero @jrieken Let's discuss tomorrow

[bpasero]

Feel free to close as duplicate of #10358 unless there is something else we need to take care of?

[alexdima]

I like that we finally have reproducible steps. @bpasero Let's discuss tomorrow, maybe we go back to having scoped contexts per editor instance.

[bpasero]

@alexandrudima I am fine revisiting that (as I have not yet started to work on disposing the editor) but I can reproduce the other issues as well easily as soon as I bring in the settings editor.

Note that untitled files also use a different editor compared to files (the same editor that settings are using), so it is similar to opening settings (but likely easier to reproduce).

[bpasero]

@alexandrudima @jrieken after talking briefly to Alex, Joh is trying to bring back the state of having a keybinding service per editor. That means I will not continue in #10358 for now.

[bpasero]

@jrieken does this mean I can revert the change in textEditor.ts of e466584 ?

[jrieken]

Why would you do that? I think not listening to events when you are invisible and potentially never visible again is generally a good thing

[bpasero]

@jrieken 👍