Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in node-oniguruma when tokenizing this malformed string with the JS grammar #10945

Closed
weinand opened this issue Aug 25, 2016 · 4 comments
Closed

Crash in node-oniguruma when tokenizing this malformed string with the JS grammar #10945

weinand opened this issue Aug 25, 2016 · 4 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues tokenization Text tokenization upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
September 2016

Comments

@weinand
Copy link
Contributor

weinand commented Aug 25, 2016 

let badStr = [9,109,46,115,101,116,40,110,117,108,108,44,32,39,233,55356,102,102,111,111,39,41,59,10].map(code => String.fromCharCode(code)).join("");
@weinand weinand added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Aug 25, 2016
@weinand weinand added this to the August 2016 milestone Aug 25, 2016
@alexdima alexdima mentioned this issue Aug 26, 2016
Closed
@alexdima alexdima added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 26, 2016
@alexdima
Copy link
Member

PR submitted: atom/node-oniguruma#57

@alexdima
Copy link
Member

Does not look like they will accept the PR in time for the August code freeze.

@alexdima alexdima modified the milestones: September 2016, August 2016 Aug 29, 2016
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug tokenization Text tokenization labels Aug 29, 2016
@alexdima
Copy link
Member

The PR to oniguruma got accepted, we adopted latest oniguruma, plus I did some work in edf6245 to prevent edits from producing invalid UTF16

@alexdima
Copy link
Member

Related #12329

@alexdima alexdima mentioned this issue Sep 27, 2016
Closed
@jrieken jrieken added the verified Verification succeeded label Sep 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues tokenization Text tokenization upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
3 participants
@jrieken @weinand @alexdima