Multi-byte entry crashes code

[seanmcbreen]

• VSCode Version: ?
• OS Version: OS X

Steps to Reproduce:
See this tweet...
https://twitter.com/matt_porter_/status/778019210806951936

[M-Porter]

@seanmcbreen oh hey.

VSCode Version: 1.5.2 (66f37fd)
OS Version: 10.11.5 (15F34)

EDIT
There's also this http://i.imgur.com/cXi3fdK.gifv

[alexdima]

@M-Porter Sorry about the crash, it occurs because we end up splitting a high surrogate - low surrogate pair, thus having on our hands an invalid UTF16 string, which we then pass to oniguruma, which also contains a bug that I introduced in the cached UTF16 - UTF8 conversion where I ignore high surrogates that are lacking a low surrogate, whereas v8's handling of the conversion interprets it as a code point.

Ref: atom/node-oniguruma#56 . A PR is already send (atom/node-oniguruma#57), I'm looking forward to getting it reviewed, otherwise we might proceed to fork the node-oniguruma project.

[M-Porter]

Awesome. Thanks for the explanation. Looking forward to being able to use vscode again.

[alexdima]

@M-Porter the PR just got accepted, as soon as there will be a new npm package, we will pick it up and the following day's insiders build will contain the fix.

[roblourens]

I verified that it's not crashing, although there are other issues like #12950