Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Notebooks - Editor + Output font size do not match (Add setting to change output font size) #119214

Closed
claudiaregio opened this issue Mar 17, 2021 · 16 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook notebook-output ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@claudiaregio
Copy link

Steps to Repro:

  1. Open settings (UI)
  2. Set editor font size to 8
  3. Open notebook, run simple print statement

Actual Behavior:

Output does not honor set editor font size
image

@rebornix rebornix added feature-request Request for new features or functionality notebook notebook-output labels Mar 18, 2021
@rebornix rebornix added this to the Backlog milestone Mar 18, 2021
@rebornix
Copy link
Member

Output does not honor set editor font size

Yup, that's why it's called "editor font size", which will only change font size of the text editor.

@claudiaregio
Copy link
Author

claudiaregio commented Mar 18, 2021

@rebornix Are there plans to add a setting for the output font size? Or some setting to have the editor font size match the output font size? Believe the customer expectation for something like a notebook would be that they are the same (by default at least)

@rebornix
Copy link
Member

@rebornix Are there plans to add a setting for the output font size? Or some setting to have the editor font size match the output font size? Believe the customer expectation for something like a notebook would be that they are the same (by default at least)

We would need to explore what's the impact on the overall look of the notebook editor.

@rebornix rebornix added the ux User experience issues label Mar 22, 2021
@claudiaregio
Copy link
Author

I see. I had two users bring this up this past week. The most recent one this weekend mentioned that they tried out vs code is because of support for Julia and theyre in search of a mathematica replacement. They like a package that Julia offers but the rendered output is too small. They provided the photo below and mentioned how the lines are thin and the terms can get small. They are aware of the ability to zoom in on the entire vsc screen but do not like that the entire UI also gets upscaled and crowds the screen.

image

The first user very specifically just wanted the size to match but did not necessarily want the default size in output that was provided.

@rebornix rebornix removed their assignment Mar 22, 2021
@miguelsolorio
Copy link
Contributor

This might be more of an output rendering request as opposed to font-size, it might be interesting to see if we could enable controls that allows users to make the output smaller/bigger and persist those.

@claudiaregio
Copy link
Author

I agree @misolori , think im tracking two different pain points here. I think the input/output general size customer expectation would be that they are same font size. For something like the math equations that is more likely rendering related.

@claudiaregio claudiaregio changed the title Native Notebooks - Editor Font Size Not Honored Native Notebooks - Editor + Output font size do not match Apr 16, 2021
@claudiaregio
Copy link
Author

+1 from customer
image

@claudiaregio
Copy link
Author

+1 from customer:
microsoft/vscode-jupyter#4031 (comment)

Hi!

This issue has been closed but I cannot find anything that describes how I can change the font family and/ or size for the code cell execution output!?

Can someone point me to an according setting, please?

Thank you,
Jamil

@claudiaregio claudiaregio changed the title Native Notebooks - Editor + Output font size do not match Native Notebooks - Editor + Output font size do not match (Add setting to change output font size) Apr 30, 2021
@claudiaregio
Copy link
Author

+1 from survey monkey

image

@claudiaregio
Copy link
Author

+1 customer feedback

image

@rebornix rebornix modified the milestones: Backlog, May 2021 May 21, 2021
@rebornix rebornix self-assigned this May 21, 2021
@rebornix
Copy link
Member

Pushed changes to align the editor font size and output font size, which look pretty good

image

@Queuecumber
Copy link

I don't think this quite addresses microsoft/vscode-jupyter#403, that was asking for a way to change the font size of specific elements rather than pointing out that there are size inconsistencies.

Is that something that is being worked on or should an issue be opened? In my case, the editor font size and output font sizes all look fine but the markdown is really small for some reason:

markuphero-4zRacRnMAp92uSoD1B2U-1

I've tried changing the "Markdown > Preview: Font Size" setting but it seems like that isnt being used here

@miguelsolorio
Copy link
Contributor

@Queuecumber this issue was for: Editor + Output font size do not match, so this does not cover rendered markdown content. Please create a new issue.

@claudiaregio
Copy link
Author

@Queuecumber I have filed the second issue here: #124872

@rebornix rebornix added the verification-needed Verification of issue is requested label Jun 1, 2021
@connor4312 connor4312 added the verified Verification succeeded label Jun 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook notebook-output ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@rebornix @connor4312 @Queuecumber @claudiaregio @miguelsolorio and others