Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Notebooks - Resize outputs with Math rendering #124872

Open
claudiaregio opened this issue May 28, 2021 · 12 comments
Open

Native Notebooks - Resize outputs with Math rendering #124872

claudiaregio opened this issue May 28, 2021 · 12 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities notebook notebook-markdown
Milestone

Comments

@claudiaregio
Copy link

Sometimes the rendering for math is quite small depending on the elements in it and there is no way to enlarge this output today. Would be great if there was some way to make this larger.

image

@Queuecumber
Copy link

Just to give some more context:

In my case, the editor font size and output font sizes all look fine but the markdown is really small for some reason:

markuphero-4zRacRnMAp92uSoD1B2U-1

I've tried changing the "Markdown > Preview: Font Size" setting but it seems like that isnt being used here. It would be great if the font size for the markdown (including equations) could be changed or if it at least respected the size setting that's already in the markdown renderer extension

@miguelsolorio
Copy link
Contributor

miguelsolorio commented May 29, 2021

@mjbvz I've noticed that the markdown renderer font size is different from the markdown preview. We should probably align these so that the markdown preview font size setting works in notebooks as well.

@rebornix rebornix removed their assignment Jun 4, 2021
@claudiaregio claudiaregio changed the title Native Notebooks - Math rendering Native Notebooks - Resize outputs with Math rendering Jun 11, 2021
@mjbvz mjbvz added feature-request Request for new features or functionality notebook-markdown labels Jun 12, 2021
@allefeld
Copy link

allefeld commented Jul 30, 2021

I don't think there even needs to be a separate setting, the important thing is that code/output font size and markdown font size match (or, if you want to get fancy, that x-height matches).

@mjbvz mjbvz added this to the Backlog Candidates milestone Aug 4, 2021
@coxackie
Copy link

@mjbvz I understand that this may not reach the required (20) upvotes, but if it is as easy a fix as to align markdown renderer and markdown preview, could this be implemented anyway? The sizing can be quite off, as the post from @Queuecumber above shows. I use jupyter notebook in classroom teaching and like to use vscode for that - markdown font too small makes the students' eyes squint to nothingness, in order to make out what is written...

@greazer greazer reopened this Oct 4, 2021
@greazer greazer assigned greazer and unassigned mjbvz Oct 5, 2021
@greazer greazer reopened this Oct 5, 2021
@coxackie
Copy link

@greazer many thanks for reopening this - I got worried it will be abandoned. Does this mean it will be considered for a fix?

@alexr00 alexr00 modified the milestones: October 2021, November 2021 Nov 1, 2021
@spinicist
Copy link

I also would very much like to see this fixed. Currently mixed Markdown & Code notebooks are very hard to read in VS Code, which is a great shame. I would have upvoted this in October if I had found this issue then. Please do not abandon this.

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 10, 2021

Resizing the rendered markdown is covered by #126294 and is now adjustable in the insiders using notebook.markup.fontSize

Leaving this issue open to cover just math outputs (inline math in markdown scales with notebook.markup.fontSize)

@spinicist
Copy link

@mjbvz Thank you! I'm looking forward to this filtering through to the general release.

@greazer greazer removed this from the January 2022 milestone Jan 31, 2022
@greazer greazer added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jan 31, 2022
@mjbvz mjbvz added the notebook label Dec 5, 2022
@mjbvz mjbvz added this to the Backlog milestone Dec 5, 2022
@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities notebook notebook-markdown
Projects
None yet
Development

No branches or pull requests

12 participants