Scrolling on mouse click

[kieferrm]

Issue Type: Bug

I have been using

"editor.cursorSurroundingLines": 5,

for a long time. Currently I end up with a LOT of inadvertant selections when working in two side-by-side editor groups and switching back and forth between them using the mouse.

The reason is that the editor scrolls 5 lines every time I click into it.

VS Code version: Code - Insiders 1.58.0-insider (012b146, 2021-06-11T05:22:19.992Z)
OS version: Darwin arm64 20.5.0
Restricted Mode: No
Remote OS version: Linux x64 5.4.0-1046-azure

[alexdima]

@kieferrm I cannot reproduce. Does this reproduce for you when disabling all extensions? (The editor exposes a revealRange API to extensions). I have recently also got #126146 which seems incredibly similar, but I am having a hard time reproducing any of the jumping that is described. Here I am trying two side-by-side editor groups:

Kapture.2021-06-14.at.17.37.58.mp4

[alexdima]

This reproduces only when the language mode of the files are set to markdown.

@mjbvz I think this has to do with how the markdown extension is using the revealRange vscode API. But I think it should not use that API at all if no markdown preview is rendered. But it would also be interesting to test what the experience is when the preview is rendered. Given this doesn't reproduce with txt files, I'm optimistically giving this to you.

Steps to reproduce:

• define "editor.cursorSurroundingLines": 5,
• open two md files side-by-side (preferably without word wrapping to see the top line number change)
• click on the editor tab of each one
• on every click, the editor scrolls up by 5 lines

Kapture.2021-06-14.at.18.20.07.mp4

[mjbvz]

@andreamah Could you please take a look at this since you were looking into markdown syncing last iteration?

[andreamah]

It seems like it's a bug coming from the scroll syncing between the static and text editor changes that I made a while ago. I'll try to make a PR to fix this soon.