-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "Feature Preview" rollout of settings/defaults. #134684
Comments
Some thoughts on this from the experiment service (now called workbench assignment service) side... @JacksonKearl had already made all the technical changes to override experiment values (explicitly on or off). The configuration service cannot rely on the assignment because it needs to rely on settings for overrides, so the settings editor should do the merging logic. Right now, overrides are hidden settings with fixed names based on the treatment variables. I would expect this could be done by adding explicit settings that would allow you to describe the experiment. The settings editor would then need to handle the different states (am i opted in or out by choice or by the treatment group). |
Love this for many reasons, as it naturally allows the rollout both via outreach leading to manual opt-in and experiments leading to opting in a random set of users. To support this for extensions, I'd love to see this |
@JacksonKearl @sbatten Can you please shed some light here - what is expected from configuration land? |
Added support for overriding default values of experimental settings through experiments service. This works in the following way:
@JacksonKearl - You can adopt your setting |
Let me know if there is any thing needs to be done here. Otherwise we are good to close it. |
@JacksonKearl / @digitarald Can you please verify this? |
Thanks a lot for working on this, @sandy081! I verified it works 🥳 I added It also shows correctly when auto completing the setting: |
Also 👍 from me. I verified with @sbatten who added the experimental flag to |
…vice for experimental settings
A few times now we've done "Phased Rollouts" of new feature (welcome, native notebooks, etc.), default setting values. It'd be nice to have some sort of standardized way both for
Perhaps an
@experiments
tag in settings editor could help here? Or something new, maybe taking inspi from GitHub's "Feature Preview" modal.cc @roblourens @digitarald @luabud
The text was updated successfully, but these errors were encountered: