Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip is missing when using keyboard to highlight tree items. #141021

Closed
smartguest opened this issue Jan 19, 2022 · 7 comments
Closed

Tooltip is missing when using keyboard to highlight tree items. #141021

smartguest opened this issue Jan 19, 2022 · 7 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan tree-views Extension tree view issues
Milestone

Comments

@smartguest
Copy link

smartguest commented Jan 19, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: N/A
  • OS Version: Windows 10

Context:

This issue was originally reported in vscode-mssql:
microsoft/vscode-mssql#17201

Steps to Reproduce:

  1. Select a treeitem using tab and arrow keys,

Actual:

  1. When using arrow keys to move to a tree item in a window, tooltip is not available with the keyboard keys.

Expected:

When using arrow keys to move to data in a window, tooltip should be available with the keyboard keys which is available with mouse.

@alexr00
Copy link
Member

alexr00 commented Jan 21, 2022

@isidorn is there a usual way to access a tooltip via keyboard that we should be following?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Jan 21, 2022
@isidorn
Copy link
Contributor

isidorn commented Jan 21, 2022

@alexr00 yeah, cmd + k, cmd + i. Works for all editor hovers. Make sure that when user access the tooltip like this that the focus is moved inside the tooltip - so the screen reader would read the proper thing

@alexr00 alexr00 added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality tree-views Extension tree view issues and removed info-needed Issue requires more information from poster labels Jan 21, 2022
@alexr00 alexr00 added this to the February 2022 milestone Jan 21, 2022
@alexr00
Copy link
Member

alexr00 commented Feb 21, 2022

I have added the ctrl + k, ctrl + i keyboard shortcut for extension tree hovers. However, when the hover is escaped, focus does not return to the tree as I think is correct. @Tyriar, is there an option I am missing when using focus = true for ensuring that focus is returned to the previously focused element when the hover is escaped?

@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2022

@alexr00 great, thanks! Looking at the code it does not look like focus is passed to the hover (I might be misinterpreting). Is it possible to move the focus to the custom hover when this command is triggered by keybinding?

alexr00 added a commit that referenced this issue Feb 21, 2022
@alexr00
Copy link
Member

alexr00 commented Feb 21, 2022

Focus is passed to the hover. I confirmed that NVDA reads the hover when shown via the keybinding.

(its this true that does it:

)

@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2022

Thanks! I missed that true.

@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2022

@alexr00 I don't think there's a mechanism for returning focus, I guess we'd want to check how the quick pick does it and adopt that in the hover service.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests

6 participants
@isidorn @Tyriar @sandy081 @smartguest @alexr00 and others